Merge #12035: [qt] change µBTC to bits
ClosedPublic
Actions

Authored by nakihito on Feb 15 2020, 01:46.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING1c4b1649e462: Merge #12035: [qt] change µBTC to bits
rABC1c4b1649e462: Merge #12035: [qt] change µBTC to bits

Summary

ebcee1de2 bips: add bip176 (Bits Denomination) (William Casarin)
275b2eeed [qt] change µBTC to bits (William Casarin)

Pull request description:

Now that we have bip176, change "µBTC" to the more colloquial "bits"

Tree-SHA512: eba5e5f89c392728a4f0a3bd81a9779a117b8d72a490390fd031d4e7cc56c2bfee0016aba7ef9535903e8cf2262ce46497283424e378906d0e3bf5b0d2d981c7

Backport of Core PR12035

The naming changes were excluded.

Test Plan

ninja
./bitcoin-qt

Options -> Display -> Units -> µBTC
Verify home screen displays proper units.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Feb 15 2020, 01:46

Owners added a reviewer: Restricted Owners Package.Feb 15 2020, 01:46

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 15 2020, 01:46

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito planned changes to this revision.Feb 15 2020, 01:49

nakihito requested review of this revision.Feb 15 2020, 01:52

nakihito edited the test plan for this revision. (Show Details)

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9509: Diff 16402.Feb 15 2020, 01:56

Is this BIP something we want ? I personally don't like it, but I'm used to the m/µ notations.

I think pulling in this backport is good because it will reduce merge conflicts and has potentially beneficial upsides if we do decide to work with long names that differ from short names.

That said, I don't agree with "bits" being a useful denomination. Some downsides include:

Does not translate well.
Has very well established meaning in computer science. This only makes documentation confusing or annoying to read (always needing to clarify uBCH/bits for all usages).

I don't think "bits" is an improvement over uBCH in general. If you fix up this patch according to my other comments, I'm willing to green it.

doc/bips.md
37 ↗	(On Diff #16402)	I think this can be removed, given my other comments.
src/qt/bitcoinunits.cpp
40 ↗	(On Diff #16402)	leave off the `(bits)`
51 ↗	(On Diff #16402)	just have this function do `return longName(unit);` as there's no reason to have other logic at this time.
62 ↗	(On Diff #16402)	remove `(bits)`