lcov: filter depends from coverage report
ClosedPublic
Actions

Authored by Fabien on Feb 17 2020, 16:59.

Details

Reviewers

jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING6a4c5c27944b: lcov: filter depends from coverage report
rABC6a4c5c27944b: lcov: filter depends from coverage report

Summary

If you build the binaries with the depends folder and then generate
coverage reports with make cov, depends will be included in the coverage
reports. Coverage of the dependencies are not that interesting and
should be filtered.

Backport of core PR17647.

Depends on D5301.

Test Plan

../configure --prefix=$PWD/../depends/x86_64-linux-gnu --enable-lcov
make
make cov

Check there is no depends/ subdir under total.coverage.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR17647

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9522
Build 16956: Default Diff Build & Tests
Build 16955: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 17 2020, 16:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 17 2020, 16:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9522: Diff 16427.Feb 17 2020, 17:09

jasonbcox accepted this revision.Feb 19 2020, 22:55

This revision is now accepted and ready to land.Feb 19 2020, 22:55

Closed by commit rABC6a4c5c27944b: lcov: filter depends from coverage report (authored by nijynot <nijynot@gmail.com>, committed by Fabien). · Explain WhyFeb 20 2020, 12:55

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC6a4c5c27944b: lcov: filter depends from coverage report.

Fabien added a commit: rSTAGING6a4c5c27944b: lcov: filter depends from coverage report.Apr 7 2020, 23:04

Revision Contents
Changeset List

Path

Size

Makefile.am

13 lines

Diff 16427

View Options

lcov: filter depends from coverage reportClosedPublicActions