Page MenuHomePhabricator

Clear the IFP bip in the version by default to avoid accidental activation
ClosedPublic

Authored by deadalnix on Feb 19 2020, 00:45.

Details

Summary

While the defautl behavior of BIP9 is to vote yes by default, it is preferable to avoid doing so accidentaly.

Test Plan
make check
./test/functional/test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Feb 19 2020, 00:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 19 2020, 00:45
jasonbcox accepted this revision.Feb 19 2020, 01:18
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/validation.cpp
1640 ↗(On Diff #16437)

Nit: This comment could be more descriptive of why these bits should be cleared.

test/functional/abc-block-sigchecks-activation.py
73 ↗(On Diff #16437)

not related, but this is just lint so I guess it doesn't really matter

This revision is now accepted and ready to land.Feb 19 2020, 01:18