[secp256k1] Remove a warning in multiset test
ClosedPublic
Actions

Authored by deadalnix on Feb 20 2020, 23:56.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGb27bc243bc48: [secp256k1] Remove a warning in multiset test
rABCb27bc243bc48: [secp256k1] Remove a warning in multiset test

Summary

The cast done is unsafe due to memory alignement constraints.

Test Plan

ninja check-secp256k1

Verify that the test passes and that the warning is gone.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

secpwarning

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9532
Build 16974: Default Diff Build & Tests
Build 16973: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 20 2020, 23:56

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 20 2020, 23:56

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B9532: Diff 16448.Feb 21 2020, 00:05

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Fabien accepted this revision.Feb 21 2020, 07:44

This revision is now accepted and ready to land.Feb 21 2020, 07:44

Closed by commit rABCb27bc243bc48: [secp256k1] Remove a warning in multiset test (authored by deadalnix). · Explain WhyFeb 23 2020, 23:36

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCb27bc243bc48: [secp256k1] Remove a warning in multiset test.

deadalnix added a commit: rSTAGINGb27bc243bc48: [secp256k1] Remove a warning in multiset test.Apr 7 2020, 23:05

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

src/

modules/

multiset/

tests_impl.h

3 lines

Diff 16448

View Options

src/secp256k1/src/modules/multiset/tests_impl.h

[secp256k1] Remove a warning in multiset testClosedPublicActions