Page MenuHomePhabricator
Differential D5314

Move check-seeds from CI to general seed tools
ClosedPublic
Actions

Authored by jasonbcox on Feb 21 2020, 18:18.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGfe11ff821ba7: Move check-seeds from CI to general seed tools
rABCfe11ff821ba7: Move check-seeds from CI to general seed tools
Summary

Originally, I put check-seeds with CI scripts because setting a specific threshold for "good" seed
connectivity seemed CI-specific to me. However, after some review (https://reviews.bitcoinabc.org/D4725?vs=on&id=14853#inline-28948)
it became clear that this tool could be more general and not actually have any CI-specific logic.

check-seeds should have been moved to contrib/seeds where it belongs since it has no CI-specific logic and
can be leveraged outside of CI.

Test Plan

Run check-seeds on CI for sanity

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jasonbcox created this revision.Feb 21 2020, 18:18
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 21 2020, 18:18
teamcity added a comment.Feb 21 2020, 18:19

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 21 2020, 18:19

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 21 2020, 18:23

Build Bitcoin-ABC / Diffs / Diff Testing passed.

teamcity added a comment.Feb 21 2020, 18:28

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9540: Diff 16457.Feb 21 2020, 18:28
Fabien accepted this revision.Feb 22 2020, 15:59
Fabien added a subscriber: Fabien.
Fabien added inline comments.
contrib/teamcity/build-configurations.sh
74 ↗(On Diff #16457)

Since this is only used for check-seeds, you should declare it there.

This revision is now accepted and ready to land.Feb 22 2020, 15:59
jasonbcox updated this revision to Diff 16467.Feb 22 2020, 17:22

Fix nit

teamcity added a comment.Feb 22 2020, 17:23

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 22 2020, 17:23

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 22 2020, 17:26

Build Bitcoin-ABC / Diffs / Diff Testing passed.

teamcity added a comment.Feb 22 2020, 17:32

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9547: Diff 16467.Feb 22 2020, 17:32
Closed by commit rABCfe11ff821ba7: Move check-seeds from CI to general seed tools (authored by jasonbcox). · Explain WhyFeb 24 2020, 16:27
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rABCfe11ff821ba7: Move check-seeds from CI to general seed tools.
jasonbcox added a commit: rSTAGINGfe11ff821ba7: Move check-seeds from CI to general seed tools.Apr 7 2020, 23:05

Revision Contents
Changeset List

PathSize
contrib/
seeds/
teamcity/
teamcity/
5 lines

Diff 16474

View Options

contrib/seeds/check-seeds.sh

Loading...
View Options

contrib/teamcity/build-configurations.sh

Loading...
View Options

contrib/teamcity/check-seeds.sh

Loading...