Page MenuHomePhabricator

Move check-seeds from CI to general seed tools
ClosedPublic

Authored by jasonbcox on Feb 21 2020, 18:18.

Details

Summary

Originally, I put check-seeds with CI scripts because setting a specific threshold for "good" seed
connectivity seemed CI-specific to me. However, after some review (https://reviews.bitcoinabc.org/D4725?vs=on&id=14853#inline-28948)
it became clear that this tool could be more general and not actually have any CI-specific logic.

check-seeds should have been moved to contrib/seeds where it belongs since it has no CI-specific logic and
can be leveraged outside of CI.

Test Plan

Run check-seeds on CI for sanity

Diff Detail

Repository
rABC Bitcoin ABC
Branch
mv-check-seeds
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9547
Build 17003: Default Diff Build & Tests
Build 17002: arc lint + arc unit

Event Timeline

Fabien added a subscriber: Fabien.
Fabien added inline comments.
contrib/teamcity/build-configurations.sh
74 ↗(On Diff #16457)

Since this is only used for check-seeds, you should declare it there.

This revision is now accepted and ready to land.Feb 22 2020, 15:59