The accounts API will be removed in the next commit. Remove all
functional tests for the accounts API.
Partial backport of Core PR14023
https://github.com/bitcoin/bitcoin/pull/14023/commits/c410f415758913c933ad6c71cf50227cc85aa385
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Owners Package (Owns No Changed Paths) Restricted Project
make check ninja check test_runner.py
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- PR14023-tests
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 9544 Build 16997: Default Diff Build & Tests Build 16996: arc lint + arc unit
Event Timeline
Comment Actions
[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.
Comment Actions
Build Bitcoin-ABC / Diffs / Diff Testing failed.
Snippet of first build failure:
[00:33:06] : [Step 1/1] [0m [0;34mrpc_deprecated.py | ✓ Passed | 1 s
[00:33:06] : [Step 1/1] [0m [0;34mrpc_estimatefee.py | ✓ Passed | 0 s
[00:33:06] : [Step 1/1] [0m [0;34mrpc_fundrawtransaction.py | ✓ Passed | 36 s
[00:33:06] : [Step 1/1] [0m [0;34mrpc_getblockstats.py | ✓ Passed | 0 s
[00:33:06] : [Step 1/1] [0m [0;34mrpc_getchaintips.py | ✓ Passed | 2 s
[00:33:06] : [Step 1/1] [0m [0;34mrpc_help.py | ✓ Passed | 0 s
[00:33:06] : [Step 1/1] [0m [0;34mrpc_invalidateblock.py | ✓ Passed | 5 s
[00:33:06] : [Step 1/1] [0m [0;34mrpc_named_arguments.py | ✓ Passed | 0 s
[00:33:06] : [Step 1/1] [0m [0;34mrpc_net.py | ✓ Passed | 1 s
[00:33:06] : [Step 1/1] [0m [0;34mrpc_preciousblock.py | ✓ Passed | 1 s
[00:33:06] : [Step 1/1] [0m [0;34mrpc_psbt.py | ✓ Passed | 8 s
[00:33:06] : [Step 1/1] [0m [0;34mrpc_rawtransaction.py | ✓ Passed | 20 s
[00:33:06] : [Step 1/1] [0m [0;34mrpc_scantxoutset.py | ✓ Passed | 3 s
[00:33:06] : [Step 1/1] [0m [0;34mrpc_signmessage.py | ✓ Passed | 0 s
[00:33:06] : [Step 1/1] [0m [0;34mrpc_signrawtransaction.py | ✓ Passed | 1 s
[00:33:06] : [Step 1/1] [0m [0;34mrpc_txoutproof.py | ✓ Passed | 2 s
[00:33:06] : [Step 1/1] [0m [0;34mrpc_uptime.py | ✓ Passed | 0 s
[00:33:06] : [Step 1/1] [0m [0;34mrpc_users.py | ✓ Passed | 2 s
[00:33:06] : [Step 1/1] [0m [0;34mrpc_zmq.py | ✓ Passed | 1 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_abandonconflict.py | ✓ Passed | 6 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_basic.py | ✓ Passed | 22 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_createwallet.py | ✓ Passed | 1 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_createwallet.py --usecli | ✓ Passed | 1 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_disable.py | ✓ Passed | 0 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_dump.py | ✓ Passed | 2 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_encryption.py | ✓ Passed | 4 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_groups.py | ✓ Passed | 11 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_hd.py | ✓ Passed | 4 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_import_rescan.py | ✓ Passed | 3 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_importmulti.py | ✓ Passed | 2 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_importprunedfunds.py | ✓ Passed | 0 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_keypool.py | ✓ Passed | 2 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_keypool_topup.py | ✓ Passed | 2 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_listreceivedby.py | ✓ Passed | 11 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_listsinceblock.py | ✓ Passed | 2 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_listtransactions.py | ✓ Passed | 6 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_multiwallet.py | ✓ Passed | 11 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_multiwallet.py --usecli | ✓ Passed | 12 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_resendwallettransactions.py | ✓ Passed | 1 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_txn_clone.py | ✓ Passed | 3 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_txn_clone.py --mineblock | ✓ Passed | 2 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_txn_doublespend.py | ✓ Passed | 2 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_txn_doublespend.py --mineblock | ✓ Passed | 2 s
[00:33:06] : [Step 1/1] [0m [0;34mwallet_zapwallettxes.py | ✓ Passed | 2 s
[00:33:06] : [Step 1/1] [0m [0;31mwallet_labels.py | ✖ Failed | 0 s
[00:33:06] : [Step 1/1] [0m [0;31m [1m
[00:33:06] : [Step 1/1] ALL | ✖ Failed | 497 s (accumulated)
[00:33:06] : [Step 1/1] [0m [0mRuntime: 115 s
[00:33:06] : [Step 1/1]
[00:33:06] : [Step 1/1] FAILED: test/CMakeFiles/check-functional
[00:33:06] : [Step 1/1] cd /home/teamcity/buildAgent/work/c4a5708f2bae7929/build/test && /usr/bin/python3.7 ./functional/test_runner.py
[00:33:06] : [Step 1/1] ninja: build stopped: subcommand failed.
[00:33:06] : [Step 1/1] *** Output of /tmp/sanitizer_logs/*.log.* ***
[00:33:06]W: [Step 1/1] ++ print_sanitizers_log
[00:33:06]W: [Step 1/1] ++ for log in "${SAN_LOG_DIR}"/*.log.*
[00:33:06]W: [Step 1/1] ++ echo '*** Output of /tmp/sanitizer_logs/*.log.* ***'
[00:33:06]W: [Step 1/1] ++ cat '/tmp/sanitizer_logs/*.log.*'
[00:33:06]W: [Step 1/1] cat: '/tmp/sanitizer_logs/*.log.*': No such file or directory
[00:33:06]W: [Step 1/1] Process exited with code 1
[00:33:06]E: [Step 1/1] Process exited with code 1 (Step: Command Line)Each failure log is accessible here:
Bitcoin ABC functional tests: wallet_labels.py
Comment Actions
I don't think it's a good idea to split this from D5316.
I understand that it will make the diff beefy, but this change alone is only reducing code coverage.