Page MenuHomePhabricator

Merge #14023: Remove accounts rpcs
ClosedPublic

Authored by nakihito on Feb 22 2020, 00:27.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC5f7aec629b38: Merge #14023: Remove accounts rpcs
Summary

bb08423d5ca866d4a139a3b57ff110d818d08b32 [doc] Add release notes for 'account' API removal (John Newbery)
1f4b865e57b4567270b1586bb1f348ab9106485d [wallet] Re-sort wallet RPC commands (John Newbery)
f0dc850bf698f7377797d7d68365d4fc79b0221c [wallet] Remove wallet account RPCs (John Newbery)

Pull request description:

This is the first part of #13825. It simply removes the RPC methods and tests.

#13825 touches lots of files and will require frequent rebasing.

Breaking it down for easier reviewing and fewer rebases.

Tree-SHA512: d29af8e7a035e4484e6b9bb56cb86592be0ec112d8ba4ce19c15d15366ff3086e89e99fca26b90c9d66f6d3e06894486d0f29948df0bb7dcb1e2c49c6887a85a

Backport of Core PR14023

Test Plan
make check
ninja check
ninja check-functional
./bitcoind
./bitcoin-cli help

Verify the account rpcs were removed.

./bitcoin-cli help sendmany

Verify the change to sendmany help text.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Feb 22 2020, 00:27
Owners added a reviewer: Restricted Owners Package.Feb 22 2020, 00:27
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 22 2020, 00:27
teamcity edited the summary of this revision. (Show Details)Feb 22 2020, 00:28

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

nakihito edited the summary of this revision. (Show Details)Feb 22 2020, 00:28
nakihito added inline comments.Feb 22 2020, 00:37
src/wallet/rpcwallet.cpp
245 ↗(On Diff #16460)

This is removed in a future PR. but I see no reason not to remove it now as leaving it in would cause an unnecessary warning in the compiler until it was removed.

nakihito planned changes to this revision.Feb 22 2020, 00:38
nakihito updated this revision to Diff 16462.Feb 22 2020, 00:59

Rebased.

Fabien requested changes to this revision.Feb 22 2020, 15:57
Fabien added a subscriber: Fabien.

See D5315, clearing my queue.

This revision now requires changes to proceed.Feb 22 2020, 15:57
nakihito planned changes to this revision.Feb 22 2020, 20:40
nakihito edited the summary of this revision. (Show Details)Feb 24 2020, 21:10
nakihito edited the test plan for this revision. (Show Details)
nakihito updated this revision to Diff 16484.Feb 24 2020, 22:53

Squashed with D5315.

nakihito planned changes to this revision.Feb 24 2020, 22:53
nakihito requested review of this revision.Mar 3 2020, 18:36
Fabien requested changes to this revision.Mar 4 2020, 07:48
Fabien added inline comments.
doc/release-notes.md
33 ↗(On Diff #16484)

Needs rebase.

src/wallet/rpcwallet.cpp
925 ↗(On Diff #16484)

Not 8

927 ↗(On Diff #16484)

The dummy element is missing (and was also previously, despite the detailed doc has it. Is this a backport missing or an oversight from another backport ?).

1500 ↗(On Diff #16484)

There is a missing EXCLUSIVE_LOCKS_REQUIRED, is there a missing backport ?

test/functional/wallet_labels.py
69 ↗(On Diff #16484)

Can you point to the missing backport and make sure there is no other code change that will be missing after this gets landed ?

This revision now requires changes to proceed.Mar 4 2020, 07:48
nakihito added inline comments.Mar 4 2020, 20:04
nakihito updated this revision to Diff 16770.Mar 4 2020, 20:18

Rebase, added braces, and fixed argument count.

nakihito added inline comments.Mar 4 2020, 20:20
src/wallet/rpcwallet.cpp
1500 ↗(On Diff #16484)

Should've been added in D4094.

Fabien requested changes to this revision.Mar 5 2020, 07:19
Fabien added inline comments.
src/wallet/rpcwallet.cpp
927 ↗(On Diff #16484)

Thanks for digging into this. Please add it to the diff, there is no reason for not fixing a known mistake and it seems appropriated to do it here since it's account/label related.

1500 ↗(On Diff #16484)

OK, agreed it's out of scope.

This revision now requires changes to proceed.Mar 5 2020, 07:19
nakihito updated this revision to Diff 16778.Mar 5 2020, 19:14

Added dummy to sendmany help.

nakihito edited the test plan for this revision. (Show Details)Mar 5 2020, 19:15
Fabien requested changes to this revision.Mar 5 2020, 20:44
Fabien added inline comments.
src/wallet/rpcwallet.cpp
928 ↗(On Diff #16778)

No, dummy is supposed to be an empty string ""

This revision now requires changes to proceed.Mar 5 2020, 20:44
jasonbcox added inline comments.
src/wallet/rpcwallet.cpp
1500 ↗(On Diff #16484)

Please be sure to follow up on this before this diff is closed out, lest it be forgotten.

Fabien accepted this revision.Mar 5 2020, 20:52

NVM, this is consistent with the other help texts

This revision is now accepted and ready to land.Mar 5 2020, 20:52
nakihito added inline comments.Mar 5 2020, 23:11
src/wallet/rpcwallet.cpp
1500 ↗(On Diff #16484)

Removed here: D5078.

This revision was automatically updated to reflect the committed changes.