Page MenuHomePhabricator

Add compile time checking for all cs_main runtime locking assertions
ClosedPublic

Authored by deadalnix on Sep 16 2019, 14:40.

Details

Summary

This turned out to be fairly different from the original due to numerous changes in our codebase.

This is a backport of Core PR13083

Test Plan
ninja all check

Using clang as a compiler

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Sep 16 2019, 14:40
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 16 2019, 14:40
Fabien requested changes to this revision.Sep 17 2019, 06:06
Fabien added a subscriber: Fabien.

What backport is it ?

This revision now requires changes to proceed.Sep 17 2019, 06:06
deadalnix requested review of this revision.Sep 17 2019, 10:36
deadalnix edited the summary of this revision. (Show Details)
Fabien accepted this revision.Sep 17 2019, 11:44
Fabien added inline comments.
src/validation.cpp
213 ↗(On Diff #11350)

This one is from PR13481

This revision is now accepted and ready to land.Sep 17 2019, 11:44