Page MenuHomePhabricator

Merge #13481: doc: Rewrite some validation docs as lock annotations
Changes PlannedPublic

Authored by nakihito on Tue, Sep 10, 00:26.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

fa324a8b15a4ef4138685b3427c895ec14faf3af doc: Rewrite some validation doc as lock annotations (MarcoFalke)

Pull request description:

#13402 added some lock annotations in comments. This pull removes them and adds clang-readable locking annotations instead.

Tree-SHA512: 2d392efa8ac4978830a9df08b2009e69d6f1ac031f62be2275ae8d7c7e483331c7f8d458d865443af907a7af27a592421c6cca6b2df3f2877e0f369b9198f383

Backport of Core PR13481
https://github.com/bitcoin/bitcoin/pull/13481/

Depends on D4029

Test Plan
../configure CXX=clang++ CC=clang
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR13481
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7378
Build 12799: Bitcoin ABC Teamcity Staging
Build 12798: arc lint + arc unit

Event Timeline

nakihito created this revision.Tue, Sep 10, 00:26
Owners added a reviewer: Restricted Owners Package.Tue, Sep 10, 00:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Sep 10, 00:26
Fabien requested changes to this revision.Tue, Sep 10, 06:42

Any reason for not porting the comments changes ?

This revision now requires changes to proceed.Tue, Sep 10, 06:42
nakihito updated this revision to Diff 11182.Tue, Sep 10, 19:20

Rebased off D4029 and added comment changes.

nakihito planned changes to this revision.Wed, Sep 11, 21:42