Page MenuHomePhabricator
Differential D3998

Merge #11044: [wallet] Keypool topup cleanups
ClosedPublic
Actions

Authored by nakihito on Sep 4 2019, 21:50.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING08e2c02735c6: Merge #11044: [wallet] Keypool topup cleanups
rABC08e2c02735c6: Merge #11044: [wallet] Keypool topup cleanups
Summary

67ceff4 [wallet] Add logging to MarkReserveKeysAsUsed (John Newbery)
1221f60 [wallet] Remove keypool_topup_cleanups (John Newbery)

Pull request description:

A couple of minor cleanups suggested by @ryanofsky here: https://github.com/bitcoin/bitcoin/pull/11022#pullrequestreview-55598940

Does not affect functionality. Not required for v0.15.

Tree-SHA512: d8d0698fd26ea49a4157e68669d5511095760c3a1ecfa3f917e3f273efbafb55c51a202d677614216eae3f796b6e8d17506b2ec2d4799a94f18981b396e65eec

Backport of Core PR11044
https://github.com/bitcoin/bitcoin/pull/11044/

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Sep 4 2019, 21:50
Owners added a reviewer: Restricted Owners Package.Sep 4 2019, 21:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 4 2019, 21:50
teamcity added a comment.Sep 4 2019, 21:50

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 4 2019, 21:52

Build Bitcoin-ABC / Diffs / Diff Testing failed.

Harbormaster failed remote builds in B7322: Diff 11090!Sep 4 2019, 21:52
teamcity added a comment.Sep 4 2019, 21:54

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Sep 4 2019, 22:01

Build Bitcoin-ABC / Diffs / Diff Testing passed.

nakihito mentioned this in D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.Sep 4 2019, 22:08
nakihito added a child revision: D3981: Merge #13081: wallet: Add compile time checking for cs_wallet runtime locking assertions.Sep 4 2019, 22:09
Fabien accepted this revision.Sep 5 2019, 06:04
This revision is now accepted and ready to land.Sep 5 2019, 06:04
This revision was landed with ongoing or failed builds.Sep 5 2019, 17:40
Closed by commit rABC08e2c02735c6: Merge #11044: [wallet] Keypool topup cleanups (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain Why
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABC08e2c02735c6: Merge #11044: [wallet] Keypool topup cleanups.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGING08e2c02735c6: Merge #11044: [wallet] Keypool topup cleanups.Sep 19 2019, 02:08

Revision Contents
Changeset List

PathSize
src/
wallet/
2 lines
7 lines

Diff 11100

View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...