Page MenuHomePhabricator

Merge #11044: [wallet] Keypool topup cleanups
ClosedPublic

Authored by nakihito on Wed, Sep 4, 21:50.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC08e2c02735c6: Merge #11044: [wallet] Keypool topup cleanups
Summary

67ceff4 [wallet] Add logging to MarkReserveKeysAsUsed (John Newbery)
1221f60 [wallet] Remove keypool_topup_cleanups (John Newbery)

Pull request description:

A couple of minor cleanups suggested by @ryanofsky here: https://github.com/bitcoin/bitcoin/pull/11022#pullrequestreview-55598940

Does not affect functionality. Not required for v0.15.

Tree-SHA512: d8d0698fd26ea49a4157e68669d5511095760c3a1ecfa3f917e3f273efbafb55c51a202d677614216eae3f796b6e8d17506b2ec2d4799a94f18981b396e65eec

Backport of Core PR11044
https://github.com/bitcoin/bitcoin/pull/11044/

Test Plan
make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Wed, Sep 4, 21:50
Owners added a reviewer: Restricted Owners Package.Wed, Sep 4, 21:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Sep 4, 21:50
Fabien accepted this revision.Thu, Sep 5, 06:04
This revision is now accepted and ready to land.Thu, Sep 5, 06:04
This revision was landed with ongoing or failed builds.Thu, Sep 5, 17:40
This revision was automatically updated to reflect the committed changes.