Page MenuHomePhabricator

Merge #13012: [doc] Add comments for chainparams.h, validation.cpp
ClosedPublic

Authored by nakihito on Sep 10 2019, 19:17.

Details

Summary

18326ae [doc] Add comments for chainparams.h, validation.cpp (James O'Beirne)

Pull request description:

Added a few comments during a leisurely read through some of the validation code. If this kind of thing seems useful, I can add similar documentation for most of the `CChainState` interface.

Tree-SHA512: a4d9db60383a8ff02e74ac326ed88902eec1ee441e8cd4e1845bcf257072673c15974225288cebf0a633e76a3410f99e2206616b4694725a2a5b0d19c78327d6

Backport of Core PR13012
https://github.com/bitcoin/bitcoin/pull/13012/

Depends on D4045

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Sep 10 2019, 19:17
Owners added a reviewer: Restricted Owners Package.Sep 10 2019, 19:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 10 2019, 19:17
jasonbcox requested changes to this revision.Sep 10 2019, 19:52
jasonbcox added inline comments.
src/validation.cpp
2854 ↗(On Diff #11181)

This top half of the comment is clearly not part of the original PR. Please add reviewer notes as to why this is the case. Otherwise reviewers are forced to assume that a dependency/backport was missed.

This revision now requires changes to proceed.Sep 10 2019, 19:52
nakihito added inline comments.Sep 10 2019, 20:18
src/validation.cpp
2854 ↗(On Diff #11181)

This was removed here: D1182. There's no real explanation why it was removed though?

nakihito requested review of this revision.Sep 10 2019, 21:26
deadalnix requested changes to this revision.Sep 11 2019, 04:51
deadalnix added inline comments.
src/validation.cpp
2854 ↗(On Diff #11181)

It was moved in the header. Regardless of what you do, do something consistent.

This revision now requires changes to proceed.Sep 11 2019, 04:51
nakihito updated this revision to Diff 11225.Sep 11 2019, 20:56

Rebased off D4045.

nakihito planned changes to this revision.Sep 11 2019, 20:56
nakihito updated this revision to Diff 13021.Sep 19 2019, 20:41

Rebased.

jasonbcox accepted this revision.Sep 20 2019, 22:44
deadalnix accepted this revision.Sep 21 2019, 11:59
This revision is now accepted and ready to land.Sep 21 2019, 11:59