Page MenuHomePhabricator
Differential D5422

[wallet] Remove CAccount and Update zapwallettxes comment
ClosedPublic
Actions

Authored by nakihito on Mar 3 2020, 22:47.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING23ee283f519a: [wallet] Remove CAccount and Update zapwallettxes comment
rABC23ee283f519a: [wallet] Remove CAccount and Update zapwallettxes comment
Summary

No longer used

Partial backport of Core PR13825
https://github.com/bitcoin/bitcoin/pull/13825/commits/a92bdd174956491457ac162af910573e59c350c7
https://github.com/bitcoin/bitcoin/pull/13825/commits/30538846964e8c7490f94d0b57580e65aaf9c5a9

Depends on D5419

Test Plan
ninja check
test_runner.py wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Mar 3 2020, 22:47
Owners added a reviewer: Restricted Owners Package.Mar 3 2020, 22:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 3 2020, 22:47
teamcity edited the summary of this revision. (Show Details)Mar 3 2020, 22:47

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 3 2020, 22:47

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Mar 3 2020, 22:57

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9720: Diff 16755.Mar 3 2020, 22:57
Fabien requested changes to this revision.Mar 4 2020, 08:18
Fabien added a subscriber: Fabien.

Please run the wallet functional tests as part of the test plan: ./test/functional/test_runner.py wallet_*. (wallet_backup is part of the extended tests).

This revision now requires changes to proceed.Mar 4 2020, 08:18
nakihito requested review of this revision.Mar 4 2020, 19:26
nakihito edited the test plan for this revision. (Show Details)

Updated test plan.

Fabien accepted this revision.Mar 5 2020, 07:52
This revision is now accepted and ready to land.Mar 5 2020, 07:52
Closed by commit rABC23ee283f519a: [wallet] Remove CAccount and Update zapwallettxes comment (authored by nakihito). · Explain WhyMar 6 2020, 19:59
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC23ee283f519a: [wallet] Remove CAccount and Update zapwallettxes comment.
nakihito added a commit: rSTAGING23ee283f519a: [wallet] Remove CAccount and Update zapwallettxes comment.Apr 7 2020, 23:16

Revision Contents
Changeset List

PathSize
src/
wallet/
2 lines
25 lines
1 line

Diff 16821

View Options

src/wallet/init.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/walletdb.h

Loading...