Page MenuHomePhabricator

[wallet] Remove ListAccountCreditDebit()
ClosedPublic

Authored by nakihito on Mar 3 2020, 19:54.

Details

Reviewers
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING5ec97bc2a80f: [wallet] Remove ListAccountCreditDebit()
rABC5ec97bc2a80f: [wallet] Remove ListAccountCreditDebit()
Summary
Test Plan
ninja check
test_runner.py wallet_*

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Mar 3 2020, 19:55

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Fabien requested changes to this revision.Mar 4 2020, 08:17
Fabien added a subscriber: Fabien.

Please run the wallet functional tests as part of the test plan: ./test/functional/test_runner.py wallet_*. (wallet_backup is part of the extended tests). I ran the tests myself for D5414 and D5415 but won't do for the whole stack.

This revision now requires changes to proceed.Mar 4 2020, 08:17
nakihito requested review of this revision.Mar 4 2020, 18:45
nakihito edited the test plan for this revision. (Show Details)

Updated test plan.

Fabien edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Mar 5 2020, 07:21
This revision was automatically updated to reflect the committed changes.