[wallet] Remove AddAccountingEntry()
ClosedPublic
Actions

Authored by nakihito on Mar 3 2020, 18:59.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGING557e4143f82f: [wallet] Remove AddAccountingEntry()
rABC557e4143f82f: [wallet] Remove AddAccountingEntry()

Summary

Function no longer used.

Partial backport of Core PR13825
https://github.com/bitcoin/bitcoin/pull/13825/commits/cf15ebd80c1f7b854c10240a979e661fe7a6d393

Depends on D5411

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Mar 3 2020, 18:59

Owners added a reviewer: Restricted Owners Package.Mar 3 2020, 18:59

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 3 2020, 18:59

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

nakihito added a child revision: D5414: [wallet] Don't rewrite accounting entries when reordering wallet transactions and remove WriteAccountingEntry().Mar 3 2020, 19:07

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9709: Diff 16738.Mar 3 2020, 19:41

nakihito added a child revision: D5418: [wallet] Remove CAccountingEntry class.Mar 3 2020, 20:16

jasonbcox accepted this revision.Mar 4 2020, 02:07

This revision is now accepted and ready to land.Mar 4 2020, 02:07

Closed by commit rABC557e4143f82f: [wallet] Remove AddAccountingEntry() (authored by nakihito). · Explain WhyMar 6 2020, 00:23

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABC557e4143f82f: [wallet] Remove AddAccountingEntry().

nakihito added a commit: rSTAGING557e4143f82f: [wallet] Remove AddAccountingEntry().Apr 7 2020, 23:15

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.h

2 lines

wallet.cpp

19 lines

Diff 16796

View Options

src/wallet/wallet.h