Page MenuHomePhabricator

Pass chain locked variables where needed
ClosedPublic

Authored by Fabien on Jan 27 2020, 14:02.

Details

Summary

This commit does not change behavior. All it does is pass new function
parameters.

Partial backport of core PR14437:
https://github.com/bitcoin/bitcoin/pull/14437/commits/081accb875412f38718f2e40ed7bbdf15e6f4ef8

Depends on D5075.

Test Plan
cmake -GNinja .. -DENABLE_WERROR=ON -DCMAKE_BUILD_TYPE=Debug
ninja check check-fonctional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Jan 27 2020, 14:02
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 27 2020, 14:02

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Fabien edited the summary of this revision. (Show Details)Jan 27 2020, 14:03
Fabien added inline comments.
src/wallet/wallet.cpp
2988 ↗(On Diff #15809)

Note to reviewers: renamed to prevent shadowing.

3052 ↗(On Diff #15809)

Would be shadowed here.

deadalnix accepted this revision.Jan 27 2020, 16:28
This revision is now accepted and ready to land.Jan 27 2020, 16:28
This revision was automatically updated to reflect the committed changes.