Page MenuHomePhabricator

Remove direct node->wallet calls in init.cpp

Authored by Fabien on Jan 27 2020, 15:47.


Route calls during node initialization and shutdown that would happen
between a node process and wallet processes through the serializable
`Chain::Client` interface, rather than `WalletInitInterface` which is
now simpler and only deals with early initialization and parameter

This commit mostly does not change behavior. The only change is that the
"Wallet disabled!" and "No wallet support compiled in!" messages are now
logged earlier during startup.

Completes backport of core PR14437:

Depends on D5078.
Completes T592.

Test Plan
ninja check check-functional

Diff Detail

rABC Bitcoin ABC
Automatic diff as part of commit; lint not applicable.
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

jasonbcox requested changes to this revision.Jan 27 2020, 20:23
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
255 ↗(On Diff #15810)

Looks like this removal was missed.

This revision now requires changes to proceed.Jan 27 2020, 20:23
This revision is now accepted and ready to land.Jan 28 2020, 19:13