Page MenuHomePhabricator

Remove direct node->wallet calls in init.cpp
ClosedPublic

Authored by Fabien on Jan 27 2020, 15:47.

Details

Summary
Route calls during node initialization and shutdown that would happen
between a node process and wallet processes through the serializable
`Chain::Client` interface, rather than `WalletInitInterface` which is
now simpler and only deals with early initialization and parameter
interaction.

This commit mostly does not change behavior. The only change is that the
"Wallet disabled!" and "No wallet support compiled in!" messages are now
logged earlier during startup.

Completes backport of core PR14437:
https://github.com/bitcoin/bitcoin/pull/14437/commits/ea961c3d7256c66146b4976ab1293db4a628c0de

Depends on D5078.
Completes T592.

Test Plan
ninja check check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14437_part5
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 9162
Build 16278: Default Diff Build & Tests
Build 16277: arc lint + arc unit

Event Timeline

Fabien created this revision.Jan 27 2020, 15:47
Herald added a reviewer: Restricted Project. · View Herald TranscriptJan 27 2020, 15:47
teamcity edited the summary of this revision. (Show Details)Jan 27 2020, 15:47

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

Fabien edited the summary of this revision. (Show Details)Jan 27 2020, 15:48
jasonbcox requested changes to this revision.Jan 27 2020, 20:23
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/wallet/init.cpp
255 ↗(On Diff #15810)

Looks like this removal was missed.

This revision now requires changes to proceed.Jan 27 2020, 20:23
Fabien updated this revision to Diff 15824.Jan 28 2020, 07:09

Fix missing removal.

jasonbcox accepted this revision.Jan 28 2020, 19:13
This revision is now accepted and ready to land.Jan 28 2020, 19:13
This revision was automatically updated to reflect the committed changes.