HomePhabricator

Remove direct node->wallet calls in init.cpp

Authored by Russell Yanofsky <russ@yanofsky.org> on Sep 28 2017, 18:13.

Description

Remove direct node->wallet calls in init.cpp

Summary:

Route calls during node initialization and shutdown that would happen
between a node process and wallet processes through the serializable
`Chain::Client` interface, rather than `WalletInitInterface` which is
now simpler and only deals with early initialization and parameter
interaction.

This commit mostly does not change behavior. The only change is that the
"Wallet disabled!" and "No wallet support compiled in!" messages are now
logged earlier during startup.

Completes backport of core PR14437:
https://github.com/bitcoin/bitcoin/pull/14437/commits/ea961c3d7256c66146b4976ab1293db4a628c0de

Depends on D5078.
Completes T592.

Test Plan:

ninja check check-functional

Reviewers: #bitcoin_abc, jasonbcox

Reviewed By: #bitcoin_abc, jasonbcox

Subscribers: jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D5079

Details

Committed
FabienJan 28 2020, 20:39
Pushed
FabienJan 28 2020, 21:12
Reviewer
Restricted Project
Differential Revision
D5079: Remove direct node->wallet calls in init.cpp
Parents
rSTAGING489f42979334: [SECP256K1] CMake: add an option to enable endomorphism
Branches
Unknown
Tags
Unknown