Page MenuHomePhabricator

Deprecate wallet 'account' API
ClosedPublic

Authored by nakihito on Mon, Nov 4, 19:33.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABC5ef562707048: Deprecate wallet 'account' API
Summary

[wallet] [rpc] Deprecate wallet 'account' API
[wallet] [tests] Add tests for accounts/labels APIs

This commit finalizes the deprecation of the wallet 'accounts' API by
removing all account arguments and return values.

RPC behaviour is slightly different if the 'accounts' or 'labels' API is
being used. Those behaviour changes are fully documented in the RPC help
text.

Partial backport of Core PR12953
https://github.com/bitcoin/bitcoin/pull/12953/commits/109e05dcd163b8ddb7f4b3550db6b9ab833b2c04
https://github.com/bitcoin/bitcoin/pull/12953/commits/72c9575f7b793e3c77bd2d631ef7345a4c31cb0d

Depends on D4369

Test Plan
make check
test_runner.py
./bitcoind -deprecatedrpc=accounts
./bitcoin-cli help getbalance
./bitcoin-cli help sendmany
./bitcoin-cli help listtransactions
./bitcoin-cli help listsinceblock
./bitcoin-cli help getaddressinfo

Repeat the above help commands, but under ./bitcoind and verify the help messages are correct.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Mon, Nov 4, 19:33
Owners added a reviewer: Restricted Owners Package.Mon, Nov 4, 19:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Nov 4, 19:33
Fabien requested changes to this revision.Tue, Nov 5, 07:50
Fabien added inline comments.
src/wallet/rpcwallet.cpp
1131 ↗(On Diff #13901)

Restore single line

1515 ↗(On Diff #13901)

I count only 5

2062 ↗(On Diff #13901)

Braces

2094 ↗(On Diff #13901)

Dito

2132 ↗(On Diff #13901)

Dito

This revision now requires changes to proceed.Tue, Nov 5, 07:50
nakihito updated this revision to Diff 13926.Tue, Nov 5, 17:03

Restored single line if, added braces, and fixed argument count check.

Fabien accepted this revision.Tue, Nov 5, 20:22
This revision is now accepted and ready to land.Tue, Nov 5, 20:22
This revision was automatically updated to reflect the committed changes.