HomePhabricator

[wallet] Deprecate account RPC methods

Authored by John Newbery <john@johnnewbery.com> on Apr 16 2018, 17:53.

Description

[wallet] Deprecate account RPC methods

Summary:
[tests] Set -deprecatedrpc=accounts in tests
[wallet] [rpc] Deprecate account RPC methods
[docs] Add release notes for deprecated 'account' API

All account RPC methods are now deprecated and can only be called if
bitcoind has been started with the -deprecatedrpc=accounts switch.
-deprecatedrpc=accounts set in related tests. Release notes also
updated.

Affected RPC methods are:

  • getaccount
  • getaccountaddress
  • getaddressesbyaccount
  • getreceivedbyaccount
  • listaccouts
  • listreceivedbyaccount
  • move
  • setaccount

Partial backport of Core PR12953
https://github.com/bitcoin/bitcoin/pull/12953/commits/3db1ba01c783c1e35782405750c308be2b6171e3
https://github.com/bitcoin/bitcoin/pull/12953/commits/3576ab126121f9bfb4d4d6195cbbe7ba30619f77
https://github.com/bitcoin/bitcoin/pull/12953/commits/cead28bbecf032b49c01ca3ae4f47aa2536cbc55

Depends on D4368

Test Plan:

make check
test_runner.py
./bitcoind
./bitcoin-cli help

Verify there are no duplicates of setlabel, getlabeladdress, getreceivedbylabel`, and listreceivedbyaddress.

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: Fabien, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D4369

Details

Committed
nakihitoNov 5 2019, 21:32
Pushed
nakihitoNov 5 2019, 21:32
Reviewer
Restricted Owners Package
Differential Revision
D4369: [wallet] Deprecate account RPC methods
Parents
rABCc8f1e8705c98: [wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table
Branches
Unknown
Tags
Unknown

Event Timeline

Nico Guiton <nico@bitframe.org> committed rABCebb948aa8725: [wallet] Deprecate account RPC methods (authored by John Newbery <john@johnnewbery.com>).Nov 5 2019, 21:32