Page MenuHomePhabricator

[wallet] Deprecate account RPC methods
ClosedPublic

Authored by nakihito on Mon, Nov 4, 19:14.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rABCebb948aa8725: [wallet] Deprecate account RPC methods
Summary

[tests] Set -deprecatedrpc=accounts in tests
[wallet] [rpc] Deprecate account RPC methods
[docs] Add release notes for deprecated 'account' API

All account RPC methods are now deprecated and can only be called if
bitcoind has been started with the -deprecatedrpc=accounts switch.
-deprecatedrpc=accounts set in related tests. Release notes also
updated.

Affected RPC methods are:

  • getaccount
  • getaccountaddress
  • getaddressesbyaccount
  • getreceivedbyaccount
  • listaccouts
  • listreceivedbyaccount
  • move
  • setaccount

Partial backport of Core PR12953
https://github.com/bitcoin/bitcoin/pull/12953/commits/3db1ba01c783c1e35782405750c308be2b6171e3
https://github.com/bitcoin/bitcoin/pull/12953/commits/3576ab126121f9bfb4d4d6195cbbe7ba30619f77
https://github.com/bitcoin/bitcoin/pull/12953/commits/cead28bbecf032b49c01ca3ae4f47aa2536cbc55

Depends on D4368

Test Plan
make check
test_runner.py
./bitcoind
./bitcoin-cli help

Verify there are no duplicates of setlabel, getlabeladdress, getreceivedbylabel`, and listreceivedbyaddress.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Mon, Nov 4, 19:14
Owners added a reviewer: Restricted Owners Package.Mon, Nov 4, 19:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Nov 4, 19:14
Fabien accepted this revision.Tue, Nov 5, 07:38
Fabien added inline comments.
test/functional/wallet_listtransactions.py
17 ↗(On Diff #13896)

Nit: [['-deprecatedrpc=accounts']] * 2

This revision is now accepted and ready to land.Tue, Nov 5, 07:38
This revision was automatically updated to reflect the committed changes.