Page MenuHomePhabricator

Merge #11626: rpc: Make `logging` RPC public
AcceptedPublic

Authored by nakihito on Jul 16 2019, 22:51.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

cabff7588 rpc: Make logging RPC public (Wladimir J. van der Laan)

Pull request description:

This started out as a developer hack but now it's useful enough for general use. Unhide the call by moving it to `control` category. This makes it documented in `help`.

Tree-SHA512: f45fa378558b552d4e2a110bf85100b0eaaa6180bb5f62cb54a251f66026d4625b670c69d85c281eebbf4b56b80b65618c51a5a593b8f9d0a04b31e95adc91f4

Backport of Core PR11626
https://github.com/bitcoin/bitcoin/pull/11626/

Depends on D3464

Test Plan
make check
./bitcoind
./bitcoin-cli help

The logging rpc should appear under the Control section.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11626
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 6874
Build 11795: Bitcoin ABC Teamcity Staging
Build 11794: arc lint + arc unit

Event Timeline

nakihito created this revision.Jul 16 2019, 22:51
Owners added a reviewer: Restricted Owners Package.Jul 16 2019, 22:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 16 2019, 22:51
jasonbcox accepted this revision.Jul 16 2019, 23:00
This revision is now accepted and ready to land.Jul 16 2019, 23:00