Page MenuHomePhabricator

Merge #11191: RPC: Improve help text and behavior of RPC-logging.
ClosedPublic

Authored by nakihito on Jul 19 2019, 23:01.

Details

Summary

c60c49b Improve help text and behavior of RPC-logging (Akio Nakamura)

Pull request description:

  1. It is allowed libevent logging to be updated during runtime, but still described that restriction in the help text. So we delete these text.
  2. Add a descrption about the evaluation order of <include> and <exclude> to clarify how debug loggig categories to be set.
  3. Add a description about the available logging category "all" which is not explained.
  4. Add "optional" to the help text of <include> and <exclude>.
  5. Add missing new lines before "Argument:".
  6. "0","1" are allowed in both array of <include> and <exclude>. "0" is ignored and "1" is treated same as "all". It is confusing, so forbid them.
  7. It always returns all logging categories with status. Fix the help text to match this behavior.

Tree-SHA512: c2142da1a9bf714af8ebc38ac0d82394e2073fc0bd56f136372e3db7b2af3b6746f8d6b0241fe66c1698c208c124deb076be83f07dec0d0a180ad150593af415

Backport Core PR11191
https://github.com/bitcoin/bitcoin/pull/11191/

Depends on D3684

Test Plan
make check
./bitcoind
./bitcoin-cli help logging

Changes should be reflected in the help text

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

nakihito created this revision.Jul 19 2019, 23:01
Owners added a reviewer: Restricted Owners Package.Jul 19 2019, 23:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 19 2019, 23:01
nakihito planned changes to this revision.Jul 19 2019, 23:01
nakihito requested review of this revision.Jul 22 2019, 17:49
nakihito edited the summary of this revision. (Show Details)
Fabien accepted this revision.Jul 23 2019, 08:50
This revision is now accepted and ready to land.Jul 23 2019, 08:50
nakihito edited the summary of this revision. (Show Details)Jul 23 2019, 16:47
nakihito added a parent revision: D3464: [rpc] Add logging RPC.