Page MenuHomePhabricator

Merge #12953: Deprecate accounts
Changes PlannedPublic

Authored by nakihito on Mon, Aug 26, 20:51.

Details

Reviewers
deadalnix
Fabien
jasonbcox
markblundeberg
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Summary

cead28b [docs] Add release notes for deprecated 'account' API (John Newbery)
72c9575 [wallet] [tests] Add tests for accounts/labels APIs (John Newbery)
109e05d [wallet] [rpc] Deprecate wallet 'account' API (John Newbery)
3576ab1 [wallet] [rpc] Deprecate account RPC methods (John Newbery)
3db1ba0 [tests] Set -deprecatedrpc=accounts in tests (John Newbery)
4e671f0 [tests] Rename rpc_listtransactions.py to wallet_listtransactions.py (John Newbery)
a28b907 [wallet] [rpc] Remove duplicate entries in rpcwallet.cpp's CRPCCommand table (John Newbery)

Pull request description:

Deprecate all accounts functionality and make it only accessible by using `-deprecatedrpc=accounts`.

Accounts specific RPCs, account arguments, and account related results all require the `-deprecatedrpc=accunts` startup option now in order to see account things.

Several wallet functional tests use the accounts system. Those tests are unchanged, except to start the nodes with `-deprecatedrpc=accounts`. We can slowly migrate those tests to use the 'label' API instead of the 'account' API before accounts are fully removed.

Tree-SHA512: 89f4ae2fe6de4a1422f1817b0997ae22d63ab5a1a558362ce923a3871f3e42963405d6573c69c27f1764679cdee5b51bf52202cc407f1361bfd8066d652f3f37

Backport of Core PR12953
https://github.com/bitcoin/bitcoin/pull/12953/

Depends on D3949 and D3997

Fixes duplicate help entry issues mentioned in discussion of D3308.

Test Plan
make check
test_runner.py

./bitcoind
./bitcoin-cli help

Verify that there are not duplicate entries for setlabel, getlabeladdress, getreceivedbylabel, and listreceivedbyaddress.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12953
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 7294
Build 12633: Bitcoin ABC Teamcity Staging
Build 12632: arc lint + arc unit

Event Timeline

nakihito created this revision.Mon, Aug 26, 20:51
Owners added a reviewer: Restricted Owners Package.Mon, Aug 26, 20:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Aug 26, 20:51
Fabien requested changes to this revision.Tue, Aug 27, 10:08

Please fix the version numbers. Next major is 0.21 not 0.30, and there are some core numbers remaining.

This revision now requires changes to proceed.Tue, Aug 27, 10:08
nakihito updated this revision to Diff 10971.Tue, Aug 27, 19:41

Fixed incorrect version numbers.

nakihito updated this revision to Diff 11049.Fri, Aug 30, 18:10

Rebased.

jasonbcox requested changes to this revision.Wed, Sep 4, 18:29
jasonbcox added inline comments.
src/wallet/rpcwallet.cpp
1040

s/toavoid/to avoid/g

1074

PR11050 has not been backported and the related changes here are missing.

1469

The param size doesn't match. Is there a missing backport?

This revision now requires changes to proceed.Wed, Sep 4, 18:29
nakihito planned changes to this revision.Wed, Sep 4, 21:44

Nits fixed. Will rebase after D3997 is greened.

src/wallet/rpcwallet.cpp
1040

Fixed.

1074

Backport here: D3997

1469

It is a missing backport, but one that I believe we purposely skipped: https://github.com/bitcoin/bitcoin/pull/10589/. Its from a line of changes that have to do with fee estimates.