Page MenuHomePhabricator
Differential D4369

[wallet] Deprecate account RPC methods
ClosedPublic
Actions

Authored by nakihito on Nov 4 2019, 19:14.

Details

Reviewers
deadalnix
Fabien
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGINGebb948aa8725: [wallet] Deprecate account RPC methods
rABCebb948aa8725: [wallet] Deprecate account RPC methods
Summary

[tests] Set -deprecatedrpc=accounts in tests
[wallet] [rpc] Deprecate account RPC methods
[docs] Add release notes for deprecated 'account' API

All account RPC methods are now deprecated and can only be called if
bitcoind has been started with the -deprecatedrpc=accounts switch.
-deprecatedrpc=accounts set in related tests. Release notes also
updated.

Affected RPC methods are:

  • getaccount
  • getaccountaddress
  • getaddressesbyaccount
  • getreceivedbyaccount
  • listaccouts
  • listreceivedbyaccount
  • move
  • setaccount

Partial backport of Core PR12953
https://github.com/bitcoin/bitcoin/pull/12953/commits/3db1ba01c783c1e35782405750c308be2b6171e3
https://github.com/bitcoin/bitcoin/pull/12953/commits/3576ab126121f9bfb4d4d6195cbbe7ba30619f77
https://github.com/bitcoin/bitcoin/pull/12953/commits/cead28bbecf032b49c01ca3ae4f47aa2536cbc55

Depends on D4368

Test Plan
make check
test_runner.py
./bitcoind
./bitcoin-cli help

Verify there are no duplicates of setlabel, getlabeladdress, getreceivedbylabel`, and listreceivedbyaddress.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR12953-3
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 7974
Build 13951: Bitcoin ABC Buildbot (legacy)
Build 13950: arc lint + arc unit

Event Timeline

nakihito created this revision.Nov 4 2019, 19:14
Owners added a reviewer: Restricted Owners Package.Nov 4 2019, 19:14
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 4 2019, 19:14
teamcity added a comment.Nov 4 2019, 19:14

Build Bitcoin-ABC / Diffs / Diff Testing started.

Harbormaster completed remote builds in B7974: Diff 13896.Nov 4 2019, 19:28
teamcity added a comment.Nov 4 2019, 19:28

Build Bitcoin-ABC / Diffs / Diff Testing passed.

nakihito added a child revision: D4370: Deprecate wallet 'account' API.Nov 4 2019, 19:33
nakihito mentioned this in D3950: Merge #12953: Deprecate accounts.Nov 4 2019, 19:33
Fabien accepted this revision.Nov 5 2019, 07:38
Fabien added inline comments.
test/functional/wallet_listtransactions.py
17

Nit: [['-deprecatedrpc=accounts']] * 2

This revision is now accepted and ready to land.Nov 5 2019, 07:38
Closed by commit rABCebb948aa8725: [wallet] Deprecate account RPC methods (authored by John Newbery <john@johnnewbery.com>, committed by nakihito). · Explain WhyNov 5 2019, 21:32
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rABCebb948aa8725: [wallet] Deprecate account RPC methods.
nakihito added a commit: rSTAGINGebb948aa8725: [wallet] Deprecate account RPC methods.Apr 7 2020, 21:36

Revision Contents
Changeset List

Diff 13896

View Options

doc/release-notes.md

Loading...
View Options

src/wallet/rpcwallet.cpp

Loading...
View Options

test/functional/rpc_deprecated.py

Loading...
View Options

test/functional/wallet_basic.py

Loading...
View Options

test/functional/wallet_import_rescan.py

Loading...
View Options

test/functional/wallet_importprunedfunds.py

Loading...
View Options

test/functional/wallet_keypool_topup.py

Loading...
View Options

test/functional/wallet_labels.py

Loading...
View Options

test/functional/wallet_listreceivedby.py

Loading...
View Options

test/functional/wallet_listsinceblock.py

Loading...
View Options

test/functional/wallet_listtransactions.py

Loading...
View Options

test/functional/wallet_txn_clone.py

Loading...
View Options

test/functional/wallet_txn_doublespend.py

Loading...