HomePhabricator

Deprecate wallet 'account' API

Authored by John Newbery <john@johnnewbery.com> on Apr 17 2018, 18:13.

Description

Deprecate wallet 'account' API

Summary:
[wallet] [rpc] Deprecate wallet 'account' API
[wallet] [tests] Add tests for accounts/labels APIs

This commit finalizes the deprecation of the wallet 'accounts' API by
removing all account arguments and return values.

RPC behaviour is slightly different if the 'accounts' or 'labels' API is
being used. Those behaviour changes are fully documented in the RPC help
text.

Partial backport of Core PR12953
https://github.com/bitcoin/bitcoin/pull/12953/commits/109e05dcd163b8ddb7f4b3550db6b9ab833b2c04
https://github.com/bitcoin/bitcoin/pull/12953/commits/72c9575f7b793e3c77bd2d631ef7345a4c31cb0d

Depends on D4369

Test Plan:

make check
test_runner.py
./bitcoind -deprecatedrpc=accounts
./bitcoin-cli help getbalance
./bitcoin-cli help sendmany
./bitcoin-cli help listtransactions
./bitcoin-cli help listsinceblock
./bitcoin-cli help getaddressinfo

Repeat the above help commands, but under ./bitcoind and verify the help messages are correct.

Reviewers: deadalnix, Fabien, jasonbcox, O1 Bitcoin ABC, #bitcoin_abc

Reviewed By: Fabien, O1 Bitcoin ABC, #bitcoin_abc

Differential Revision: https://reviews.bitcoinabc.org/D4370

Details

Committed
nakihitoNov 5 2019, 21:36
Pushed
nakihitoNov 5 2019, 21:37
Reviewer
Restricted Owners Package
Differential Revision
D4370: Deprecate wallet 'account' API
Parents
rABCebb948aa8725: [wallet] Deprecate account RPC methods
Branches
Unknown
Tags
Unknown

Event Timeline

Nico Guiton <nico@bitframe.org> committed rABC5ef562707048: Deprecate wallet 'account' API (authored by John Newbery <john@johnnewbery.com>).Nov 5 2019, 21:36