Page MenuHomePhabricator

Don't use std::quick_exit() as it is poorly supported
ClosedPublic

Authored by Fabien on Feb 24 2020, 10:25.

Details

Summary

Despite being standard, it appears that quick_exit() is not available
on most non glibc platforms. In particular it breaks the tests build on
OSX.
This diff reverts D5254 in favor of D5232 (credits to @markblundeberg).
Despite being more hacky, it is more portable in definitive.

Test Plan

On Linux and OSX:

ninja check

Note that windows is unaffected as the test is not built for this
platform.

valgrind ./src/test/test_bitcoin --logger=JUNIT  -t util_tests

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable