Page MenuHomePhabricator

depends: latest rapidcheck, use INSTALL_ALL_EXTRAS
ClosedPublic

Authored by Fabien on Feb 25 2020, 15:15.

Details

Summary
This updates RapidCheck to the latest version available from
https://github.com/emil-e/rapidcheck.

RapidCheck now uses the new RC_INSTALL_ALL_EXTRAS option, to install the
extra boost_test packages, which should unblock progress in #14430.

Backport of core PR14853.

Depends on D5323.

Test Plan

Assuming you are running a 64-bit Linux machine:

cd depends
RAPIDCHECK=1 make build-linux64

Check the rapidcheck package is built.

cd .. && mkdir buildLinux64 && cd buildLinux64
cmake -GNinja .. \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Linux64.cmake \
  -DENABLE_PROPERTY_BASED_TESTS=ON

Check the rapidcheck lib found is the one from the depends.

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14853
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9558
Build 17023: Default Diff Build & Tests
Build 17022: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Feb 26 2020, 19:04