Page MenuHomePhabricator
Differential D5324

depends: latest rapidcheck, use INSTALL_ALL_EXTRAS
ClosedPublic
Actions

Authored by Fabien on Feb 25 2020, 15:15.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING33d30ef033ca: depends: latest rapidcheck, use INSTALL_ALL_EXTRAS
rABC33d30ef033ca: depends: latest rapidcheck, use INSTALL_ALL_EXTRAS
Summary
This updates RapidCheck to the latest version available from
https://github.com/emil-e/rapidcheck.

RapidCheck now uses the new RC_INSTALL_ALL_EXTRAS option, to install the
extra boost_test packages, which should unblock progress in #14430.

Backport of core PR14853.

Depends on D5323.

Test Plan

Assuming you are running a 64-bit Linux machine:

cd depends
RAPIDCHECK=1 make build-linux64

Check the rapidcheck package is built.

cd .. && mkdir buildLinux64 && cd buildLinux64
cmake -GNinja .. \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Linux64.cmake \
  -DENABLE_PROPERTY_BASED_TESTS=ON

Check the rapidcheck lib found is the one from the depends.

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14853
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9558
Build 17023: Default Diff Build & Tests
Build 17022: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 25 2020, 15:15
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 25 2020, 15:15
teamcity edited the summary of this revision. (Show Details)Feb 25 2020, 15:15

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 25 2020, 15:15

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added a child revision: D5325: build: dont compile rapidcheck with -Wall.Feb 25 2020, 15:21
teamcity added a comment.Feb 25 2020, 15:25

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9558: Diff 16488.Feb 25 2020, 15:25
Fabien edited the summary of this revision. (Show Details)Feb 25 2020, 15:43
Fabien added a parent revision: D5323: Integration of property based testing into Bitcoin ABC.
Fabien removed a parent revision: D5223: clean up STANDARD_NOT_MANDATORY_VERIFY_FLAGS.
Fabien mentioned this in D5323: Integration of property based testing into Bitcoin ABC.Feb 26 2020, 12:26
jasonbcox accepted this revision.Feb 26 2020, 19:04
This revision is now accepted and ready to land.Feb 26 2020, 19:04
Closed by commit rABC33d30ef033ca: depends: latest rapidcheck, use INSTALL_ALL_EXTRAS (authored by fanquake <fanquake@gmail.com>, committed by Fabien). · Explain WhyFeb 27 2020, 13:51
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC33d30ef033ca: depends: latest rapidcheck, use INSTALL_ALL_EXTRAS.
Fabien added a commit: rSTAGING33d30ef033ca: depends: latest rapidcheck, use INSTALL_ALL_EXTRAS.Apr 7 2020, 23:06

Revision Contents
Changeset List

PathSize
depends/
2 lines
packages/
21 lines

Diff 16488

View Options

depends/README.md

Loading...
View Options

depends/packages/rapidcheck.mk

Loading...