Page MenuHomePhabricator
Differential D5325

build: dont compile rapidcheck with -Wall
ClosedPublic
Actions

Authored by Fabien on Feb 25 2020, 15:21.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGd4cf781adab0: build: dont compile rapidcheck with -Wall
rABCd4cf781adab0: build: dont compile rapidcheck with -Wall
Summary

This fixes the depends build with GCC 9.1.

Backport of core PR16271.

Depends on D5324.

Test Plan

Assuming you are running a 64-bit Linux machine:

cd depends
RAPIDCHECK=1 make build-linux64

Check the rapidcheck package is built.

cd .. && mkdir buildLinux64 && cd buildLinux64
cmake -GNinja .. \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Linux64.cmake \
  -DENABLE_PROPERTY_BASED_TESTS=ON

Check the rapidcheck lib found is the one from the depends.

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 25 2020, 15:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 25 2020, 15:21
teamcity edited the summary of this revision. (Show Details)Feb 25 2020, 15:21

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 25 2020, 15:21

Build Bitcoin-ABC / Diffs / Diff Testing started.

Fabien added a child revision: D5326: build: update RapidCheck Makefile.Feb 25 2020, 15:25
teamcity added a comment.Feb 25 2020, 15:35

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9559: Diff 16489.Feb 25 2020, 15:35
jasonbcox accepted this revision.Feb 26 2020, 19:07
This revision is now accepted and ready to land.Feb 26 2020, 19:07
Closed by commit rABCd4cf781adab0: build: dont compile rapidcheck with -Wall (authored by fanquake <fanquake@gmail.com>, committed by Fabien). · Explain WhyFeb 27 2020, 13:53
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCd4cf781adab0: build: dont compile rapidcheck with -Wall.
Fabien added a commit: rSTAGINGd4cf781adab0: build: dont compile rapidcheck with -Wall.Apr 7 2020, 23:06

Revision Contents
Changeset List

PathSize
depends/
packages/
4 lines

Diff 16537

View Options

depends/packages/rapidcheck.mk

Loading...