Page MenuHomePhabricator
Differential D5326

build: update RapidCheck Makefile
ClosedPublic
Actions

Authored by Fabien on Feb 25 2020, 15:25.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING6f7a7256394f: build: update RapidCheck Makefile
rABC6f7a7256394f: build: update RapidCheck Makefile
Summary
- update RapidCheck to latest commit on master
- install only the extras needed by Bitcoin Core
- update shasum hash
- remove CMake warning

Backport of core PR16654.

Depends on D5325.

Test Plan

Assuming you are running a 64-bit Linux machine:

cd depends
RAPIDCHECK=1 make build-linux64

Check the rapidcheck package is built, and the cmake warning is gone.

cd .. && mkdir buildLinux64 && cd buildLinux64
cmake -GNinja .. \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Linux64.cmake \
  -DENABLE_PROPERTY_BASED_TESTS=ON

Check the rapidcheck lib found is the one from the depends.

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR16654
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9560
Build 17027: Default Diff Build & Tests
Build 17026: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 25 2020, 15:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 25 2020, 15:25
teamcity edited the summary of this revision. (Show Details)Feb 25 2020, 15:26

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

teamcity added a comment.Feb 25 2020, 15:26

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 25 2020, 15:35

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9560: Diff 16490.Feb 25 2020, 15:35
jasonbcox accepted this revision.Feb 26 2020, 19:08
This revision is now accepted and ready to land.Feb 26 2020, 19:08
Closed by commit rABC6f7a7256394f: build: update RapidCheck Makefile (authored by Jon Atack <jon@atack.com>, committed by Fabien). · Explain WhyFeb 27 2020, 13:54
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC6f7a7256394f: build: update RapidCheck Makefile.
Fabien added a commit: rSTAGING6f7a7256394f: build: update RapidCheck Makefile.Apr 7 2020, 23:06

Revision Contents
Changeset List

PathSize
depends/
packages/
6 lines

Diff 16490

View Options

depends/packages/rapidcheck.mk

Loading...