Page MenuHomePhabricator

build: update RapidCheck Makefile
ClosedPublic

Authored by Fabien on Feb 25 2020, 15:25.

Details

Summary
- update RapidCheck to latest commit on master
- install only the extras needed by Bitcoin Core
- update shasum hash
- remove CMake warning

Backport of core PR16654.

Depends on D5325.

Test Plan

Assuming you are running a 64-bit Linux machine:

cd depends
RAPIDCHECK=1 make build-linux64

Check the rapidcheck package is built, and the cmake warning is gone.

cd .. && mkdir buildLinux64 && cd buildLinux64
cmake -GNinja .. \
  -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Linux64.cmake \
  -DENABLE_PROPERTY_BASED_TESTS=ON

Check the rapidcheck lib found is the one from the depends.

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR16654
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9560
Build 17027: Default Diff Build & Tests
Build 17026: arc lint + arc unit

Event Timeline

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those Bitcoin Core PRs have been inserted into the summary for reference.

This revision is now accepted and ready to land.Feb 26 2020, 19:08
This revision was automatically updated to reflect the committed changes.