Page MenuHomePhabricator

Remove GotVersion()
ClosedPublic

Authored by nakihito on Feb 27 2020, 23:01.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING0c9c1fa7b21a: Remove GotVersion()
rABC0c9c1fa7b21a: Remove GotVersion()
Summary

GotVersion() is horribly named and does not actually described what it
is doing (rather, it describes when it is called which is confusing and
useless). Additionally, it only has one call site remaining, so replacing it
inline would make the code easier to read.

Test Plan
ninja

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Owners added a reviewer: Restricted Owners Package.Feb 27 2020, 23:01
nakihito retitled this revision from Rename GotVersion() to RequestAddrs() to Remove GotVersion().Feb 27 2020, 23:22
nakihito edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Feb 27 2020, 23:25
This revision was automatically updated to reflect the committed changes.