HomePhabricator

Remove GotVersion()

Description

Remove GotVersion()

Summary:
GotVersion() is horribly named and does not actually described what it
is doing (rather, it describes when it is called which is confusing and
useless). Additionally, it only has one call site remaining, so replacing it
inline would make the code easier to read.

Test Plan:

ninja

Reviewers: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox

Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, jasonbcox

Differential Revision: https://reviews.bitcoinabc.org/D5344

Details

Provenance
nakihitoAuthored on Feb 27 2020, 22:59
nakihitoPushed on Feb 28 2020, 02:12
Reviewer
Restricted Owners Package
Differential Revision
D5344: Remove GotVersion()
Parents
rABC30ed56545064: Avoid calling secp256k1_*_is_zero when secp256k1_*_set_b32 fails.
Branches
Unknown
Tags
Unknown