Page MenuHomePhabricator

Avoid calling secp256k1_*_is_zero when secp256k1_*_set_b32 fails.
ClosedPublic

Authored by deadalnix on Feb 28 2020, 00:22.

Details

Summary

Most of the codebase correctly used short-cutting to avoid calling
_is_zero on possibly incompletely initialized elements, but a few
places were missed.

This is a backport of libsecp256k1 PR629

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
secppr578
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9606
Build 17112: Default Diff Build & Tests
Build 17111: arc lint + arc unit