Moved a dereference so the null check will be before the dereferencing
ClosedPublic
Actions

Authored by deadalnix on Feb 28 2020, 00:42.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGf4a6d50e4e12: Moved a dereference so the null check will be before the dereferencing
rABCf4a6d50e4e12: Moved a dereference so the null check will be before the dereferencing

Summary

This is a backport of libsecp256k1 PR644

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Branch

secppr644

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9611
Build 17122: Default Diff Build & Tests
Build 17121: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 28 2020, 00:42

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 28 2020, 00:42

Build Bitcoin-ABC / Diffs / Diff Testing started.

nakihito accepted this revision.Feb 28 2020, 00:55

This revision is now accepted and ready to land.Feb 28 2020, 00:55

Harbormaster completed remote builds in B9611: Diff 16569.Feb 28 2020, 01:01

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Closed by commit rABCf4a6d50e4e12: Moved a dereference so the null check will be before the dereferencing (authored by Elichai Turkel <elichai.turkel@gmail.com>, committed by deadalnix). · Explain WhyFeb 28 2020, 01:12

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABCf4a6d50e4e12: Moved a dereference so the null check will be before the dereferencing.

deadalnix added a commit: rSTAGINGf4a6d50e4e12: Moved a dereference so the null check will be before the dereferencing.Apr 7 2020, 23:07

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

src/

ecmult_impl.h

3 lines

Diff 16569

View Options

src/secp256k1/src/ecmult_impl.h

Moved a dereference so the null check will be before the dereferencingClosedPublicActions