tests.c: Properly handle sscanf return value
ClosedPublic
Actions

Authored by deadalnix on Feb 28 2020, 01:01.

Details

Reviewers

nakihito

Group Reviewers

Restricted Project

Commits

rSTAGING7116a8096f6b: secp256k1/src/tests.c: Properly handle sscanf return value
rABC7116a8096f6b: secp256k1/src/tests.c: Properly handle sscanf return value

Summary

This pull request fixes a bug which allows the sh variable to be used uninitialized when sscanf returns EOF.

Signed-off-by: Mustapha Abiola <mustapha@trilemma.net>

This is a backport of secp256k1 PR650

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

deadalnix created this revision.Feb 28 2020, 01:01

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 28 2020, 01:01

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9615: Diff 16573.Feb 28 2020, 01:21

nakihito accepted this revision.Feb 28 2020, 01:31

This revision is now accepted and ready to land.Feb 28 2020, 01:31

Closed by commit rABC7116a8096f6b: secp256k1/src/tests.c: Properly handle sscanf return value (authored by Mustapha Abiola <mustapha@trilemma.net>, committed by deadalnix). · Explain WhyFeb 28 2020, 01:36

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC7116a8096f6b: secp256k1/src/tests.c: Properly handle sscanf return value.

deadalnix added a commit: rSTAGING7116a8096f6b: secp256k1/src/tests.c: Properly handle sscanf return value.Apr 7 2020, 23:08

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

src/

tests.c

2 lines

Diff 16588

View Options

secp256k1/src/tests.c: Properly handle sscanf return valueClosedPublicActions