Page MenuHomePhabricator
Differential D5360

Make gen-manpages.sh return non-zero if the script fails at any point
ClosedPublic
Actions

Authored by jasonbcox on Feb 28 2020, 01:32.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING93c7e64227f9: Make gen-manpages.sh return non-zero if the script fails at any point
rABC93c7e64227f9: Make gen-manpages.sh return non-zero if the script fails at any point
Summary

The script can fail if one of the binaries doesn't exist or cannot be run for some reason,
but these failures do not cause the script to return a non-zero exit code.

This patch makes the script return non-zero for these cases as well as cleaning up correctly.

Test Plan
cd build
ninja
cd ..
BUILDDIR=$PWD/build contrib/devtools/gen-manpages.sh  # succeeds

rm build/src/qt/bitcoin-qt
BUILDDIR=$PWD/build contrib/devtools/gen-manpages.sh  # fails

Diff Detail

Repository
rABC Bitcoin ABC
Branch
manpage-exit-on-failure
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9619
Build 17138: Default Diff Build & Tests
Build 17137: arc lint + arc unit

Revision Contents
Changeset List

PathSize
contrib/
devtools/
9 lines

Diff 16584

View Options

contrib/devtools/gen-manpages.sh

Loading...