Differential D5372

Fix CPack NSIS homepage
ClosedPublic
Actions

Authored by jasonbcox on Feb 28 2020, 21:05.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING077e243c6a7d: Fix CPack NSIS homepage
rABC077e243c6a7d: Fix CPack NSIS homepage

Summary

BITCOINABC_HOMEPAGE_URL does not exist. Use the existing homepage that is already set.

Test Plan

Setup win64 cross build:

cd depends
make build-win64
cd ..
mkdir build-win64
cmake -GNinja .. -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win64.cmake -DBUILD_BITCOIN_SEEDER=OFF

Build the package and inspect build contents:

ninja package
less _CPack_Packages/x86_64-w64-mingw32/NSIS/project.nsi  # verify URL is set
less CPackConfig.cmake  # verify homepage is set

Diff Detail

Repository

rABC Bitcoin ABC

Branch

nsis-homepage

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9644
Build 17188: Default Diff Build & Tests
Build 17187: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Feb 28 2020, 21:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 28 2020, 21:05

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9644: Diff 16629.Feb 28 2020, 21:21

Good catch, this was removed when cmake was updated to 3.12

This revision is now accepted and ready to land.Feb 28 2020, 23:18

Closed by commit rABC077e243c6a7d: Fix CPack NSIS homepage (authored by jasonbcox). · Explain WhyFeb 29 2020, 00:54

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rABC077e243c6a7d: Fix CPack NSIS homepage.

jasonbcox added a commit: rSTAGING077e243c6a7d: Fix CPack NSIS homepage.Apr 7 2020, 23:10

Revision Contents
Changeset List

Path

Size

cmake/

modules/

PackageOptions.cmake

2 lines

Diff 16629

View Options

cmake/modules/PackageOptions.cmake

Fix CPack NSIS homepageClosedPublicActions