Page MenuHomePhabricator

Fix CPack NSIS homepage
ClosedPublic

Authored by jasonbcox on Feb 28 2020, 21:05.

Details

Summary

BITCOINABC_HOMEPAGE_URL does not exist. Use the existing homepage that is already set.

Test Plan

Setup win64 cross build:

cd depends
make build-win64
cd ..
mkdir build-win64
cmake -GNinja .. -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win64.cmake -DBUILD_BITCOIN_SEEDER=OFF

Build the package and inspect build contents:

ninja package
less _CPack_Packages/x86_64-w64-mingw32/NSIS/project.nsi  # verify URL is set
less CPackConfig.cmake  # verify homepage is set

Diff Detail

Repository
rABC Bitcoin ABC
Branch
nsis-homepage
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9644
Build 17188: Default Diff Build & Tests
Build 17187: arc lint + arc unit