Page MenuHomePhabricator
Differential D5389

doc: document the length requirements of output parameter.
ClosedPublic
Actions

Authored by deadalnix on Feb 29 2020, 18:36.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGc676868b398c: doc: document the length requirements of output parameter.
rABCc676868b398c: doc: document the length requirements of output parameter.
Summary

It's subtle, since it is actually only touched by hashfp (though
we assert it's non-NULL), but give explicit advice in the default
case.

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>

This is a backport of libsecp256k1 PR714.

Test Plan
ninja check-secp256k1

Diff Detail

Repository
rABC Bitcoin ABC
Branch
secppr714
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9670
Build 17238: Default Diff Build & Tests
Build 17237: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 29 2020, 18:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 29 2020, 18:36
teamcity added a comment.Feb 29 2020, 18:36

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Feb 29 2020, 18:45

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9670: Diff 16668.Feb 29 2020, 18:45
deadalnix added a child revision: D5390: Clarify that a secp256k1_ecdh_hash_function must return 0 or 1.Feb 29 2020, 22:51
Fabien accepted this revision.Mar 2 2020, 08:11
Fabien edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Mar 2 2020, 08:11
Closed by commit rABCc676868b398c: doc: document the length requirements of output parameter. (authored by Rusty Russell <rusty@rustcorp.com.au>, committed by deadalnix). · Explain WhyMar 2 2020, 15:14
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCc676868b398c: doc: document the length requirements of output parameter..
deadalnix added a commit: rSTAGINGc676868b398c: doc: document the length requirements of output parameter..Apr 7 2020, 23:11

Revision Contents
Changeset List

PathSize
src/
secp256k1/
include/
11 lines

Diff 16668

View Options

src/secp256k1/include/secp256k1_ecdh.h

Loading...