Clarify that a secp256k1_ecdh_hash_function must return 0 or 1
ClosedPublic
Actions

Authored by deadalnix on Feb 29 2020, 22:51.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING70765825f824: Clarify that a secp256k1_ecdh_hash_function must return 0 or 1
rABC70765825f824: Clarify that a secp256k1_ecdh_hash_function must return 0 or 1

Summary

and improve style of the ECDH docs.

This is a backport of libsecp256k1 PR718

Depends on D5389

Test Plan

ninja check-secp256k1

Diff Detail

Repository

rABC Bitcoin ABC

Branch

secppr718

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9671
Build 17240: Default Diff Build & Tests
Build 17239: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 29 2020, 22:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 29 2020, 22:51

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9671: Diff 16669.Feb 29 2020, 23:00

Fabien accepted this revision.Mar 2 2020, 08:14

This revision is now accepted and ready to land.Mar 2 2020, 08:14

Closed by commit rABC70765825f824: Clarify that a secp256k1_ecdh_hash_function must return 0 or 1 (authored by Tim Ruffing <crypto@timruffing.de>, committed by deadalnix). · Explain WhyMar 2 2020, 15:25

This revision was automatically updated to reflect the committed changes.

deadalnix added a commit: rABC70765825f824: Clarify that a secp256k1_ecdh_hash_function must return 0 or 1.

deadalnix added a commit: rSTAGING70765825f824: Clarify that a secp256k1_ecdh_hash_function must return 0 or 1.Apr 7 2020, 23:11

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

include/

secp256k1_ecdh.h

26 lines

src/

modules/

ecdh/

main_impl.h

6 lines

Diff 16669

View Options

src/secp256k1/include/secp256k1_ecdh.h