Page MenuHomePhabricator
Differential D5396

[DOC] Update the subtree section from the developer notes
ClosedPublic
Actions

Authored by Fabien on Mar 2 2020, 15:36.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGING743378a67702: [DOC] Update the subtree section from the developer notes
rABC743378a67702: [DOC] Update the subtree section from the developer notes
Summary

This section is not applicable to Bitcoin ABC since there is no subtree.

The documentation is updated to give advices for making changes to third
party libraries instead, and secp256k1 is removed from the list.

Test Plan

Read it.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 2 2020, 15:36
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 2 2020, 15:36
teamcity added a comment.Mar 2 2020, 17:15

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Mar 2 2020, 17:27

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9682: Diff 16694.Mar 2 2020, 17:27
deadalnix requested changes to this revision.Mar 2 2020, 23:32
deadalnix added a subscriber: deadalnix.
deadalnix added inline comments.
doc/developer-notes.md
727 ↗(On Diff #16694)

Even though we use a modified version of it, general doc applies.

This revision now requires changes to proceed.Mar 2 2020, 23:32
Fabien updated this revision to Diff 16720.Mar 3 2020, 07:28

Reintroduce secp256k1 (modified), update the index.

teamcity added a comment.Mar 3 2020, 07:28

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Mar 3 2020, 07:38

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9699: Diff 16720.Mar 3 2020, 07:38
jasonbcox accepted this revision.Mar 3 2020, 18:10
deadalnix accepted this revision.Mar 4 2020, 18:26
This revision is now accepted and ready to land.Mar 4 2020, 18:26
Closed by commit rABC743378a67702: [DOC] Update the subtree section from the developer notes (authored by Fabien). · Explain WhyMar 4 2020, 20:41
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC743378a67702: [DOC] Update the subtree section from the developer notes.
Fabien added a commit: rSTAGING743378a67702: [DOC] Update the subtree section from the developer notes.Apr 7 2020, 23:14

Revision Contents
Changeset List

PathSize
doc/
41 lines

Diff 16773

View Options

doc/developer-notes.md

Loading...