Rename seeder_tests to p2p_messaging_tests
ClosedPublic
Actions

Authored by nakihito on Mar 2 2020, 22:58.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGd50368de0819: Rename seeder_tests to p2p_messaging_tests
rABCd50368de0819: Rename seeder_tests to p2p_messaging_tests

Summary

seeder_tests is vague and does not properly describe what is being
tested. p2p_messaging_tests better describes what is being
tested.

Test Plan

make check
ninja check
ninja check-bitcoin-seeder

Diff Detail

Repository

rABC Bitcoin ABC

Branch

RenameSeederTests

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 9703
Build 17299: Default Diff Build & Tests
Build 17298: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 2 2020, 22:58

Owners added a reviewer: Restricted Owners Package.Mar 2 2020, 22:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 2 2020, 22:58

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9691: Diff 16707.Mar 2 2020, 23:09

nakihito mentioned this in D5380: [seeder] Require good seeds to have latest checkpoint.Mar 2 2020, 23:29

message_processing_tests is a clear artifact from the code that doesn't actually tell us much, but does raise questions. What kind of messages? What "processing" is going on? Why not something like p2p_message_tests? It answers the first question, although the second is not really that interesting since again, that part is an artifact from the implementation.

This revision now requires changes to proceed.Mar 2 2020, 23:42

message_processing_tests -> p2p_messaging_tests.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9703: Diff 16728.Mar 3 2020, 17:07

nakihito retitled this revision from Rename seeder_tests to message_processing_tests to Rename seeder_tests to p2p_messaging_tests.Mar 3 2020, 18:09

nakihito edited the summary of this revision. (Show Details)

jasonbcox accepted this revision.Mar 3 2020, 18:11

This revision is now accepted and ready to land.Mar 3 2020, 18:11

Closed by commit rABCd50368de0819: Rename seeder_tests to p2p_messaging_tests (authored by nakihito). · Explain WhyMar 3 2020, 18:14

This revision was automatically updated to reflect the committed changes.

nakihito added a commit: rABCd50368de0819: Rename seeder_tests to p2p_messaging_tests.