[SECP256K1] Fix travis failure on ECMULT_GEN_PRECISION
ClosedPublic
Actions

Authored by Fabien on Mar 3 2020, 08:22.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGefcefc043ffd: [SECP256K1] Fix travis failure on ECMULT_GEN_PRECISION
rABCefcefc043ffd: [SECP256K1] Fix travis failure on ECMULT_GEN_PRECISION

Summary

The auto value is invalid on cmake, this case should be handled to not
assign any value to SECP256K1_ECMULT_GEN_PRECISION so that the default
behavior is tested.

Test Plan

Run the Travis build (see
https://travis-ci.org/Fabcien/secp256k1/builds/657636884, failures are
unrelated and deserve a separate fix).

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 3 2020, 08:22

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 3 2020, 08:22

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9701: Diff 16724.Mar 3 2020, 08:41

Fabien added a child revision: D5408: [SECP256K1] Fix Travis failures due to APT addon.Mar 3 2020, 10:54

deadalnix accepted this revision.Mar 3 2020, 23:11

This revision is now accepted and ready to land.Mar 3 2020, 23:11

Closed by commit rABCefcefc043ffd: [SECP256K1] Fix travis failure on ECMULT_GEN_PRECISION (authored by Fabien). · Explain WhyMar 4 2020, 07:07

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCefcefc043ffd: [SECP256K1] Fix travis failure on ECMULT_GEN_PRECISION.

Fabien added a commit: rSTAGINGefcefc043ffd: [SECP256K1] Fix travis failure on ECMULT_GEN_PRECISION.Apr 7 2020, 23:13

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

travis/

build_cmake.sh

9 lines

Diff 16763

View Options

src/secp256k1/travis/build_cmake.sh

[SECP256K1] Fix travis failure on ECMULT_GEN_PRECISIONClosedPublicActions