Paths

Table of Contentst

Differential D5434

[SECP256K1] Fix issue where travis does not show the logs
ClosedPublic
Actions

Authored by Fabien on Mar 5 2020, 11:50.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGINGad817c9d514f: [SECP256K1] Fix issue where travis does not show the logs
rABCad817c9d514f: [SECP256K1] Fix issue where travis does not show the logs

Summary

I noticed that according to the doc tests.log should contain stdout as
well as stderr. But it doesn't because stdout isn't flushed. I removed
buffering completely to avoid having to call fflush twice.

Backport of secp256k1 PR685.

Depends on D5433.

It slightly varies from the PR by only printing the logs in the event of
a failure.

There is no need to explicitly cat the logs with the cmake build because
they are already printed by the test runner in case of failure.

Before: https://travis-ci.org/Fabcien/secp256k1/jobs/658610743
After: https://travis-ci.org/Fabcien/secp256k1/jobs/658631083

Test Plan

Run the Travis build (see
https://travis-ci.org/Fabcien/secp256k1/builds/658633612).

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Mar 5 2020, 11:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 5 2020, 11:50

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

Build Bitcoin-ABC / Diffs / Diff Testing started.

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9735: Diff 16777.Mar 5 2020, 12:01

Why aren't the log printed in the cmake build as well?

src/secp256k1/travis/build_autotools.sh
39 ↗	(On Diff #16777)	What does this double mouthy smiley do? He doesn't look amused anyways :/

deadalnix requested changes to this revision.Mar 5 2020, 17:01

This revision now requires changes to proceed.Mar 5 2020, 17:01

Let me quote the summary :)

There is no need to explicitly cat the logs with the cmake build because they are already printed by the test runner in case of failure.

src/secp256k1/travis/build_autotools.sh
39 ↗	(On Diff #16777)	`:` is an alias for `true`. This is a usual pattern to say that I don't care about the return code of `cat`.

deadalnix accepted this revision.Mar 5 2020, 23:37

This revision is now accepted and ready to land.Mar 5 2020, 23:37

Closed by commit rABCad817c9d514f: [SECP256K1] Fix issue where travis does not show the logs (authored by Jonas Nick <jonasd.nick@gmail.com>, committed by Fabien). · Explain WhyMar 6 2020, 18:24

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCad817c9d514f: [SECP256K1] Fix issue where travis does not show the logs.

Fabien added a commit: rSTAGINGad817c9d514f: [SECP256K1] Fix issue where travis does not show the logs.Apr 7 2020, 23:16

Revision Contents
Changeset List

Path

Size

src/

secp256k1/

src/

tests.c

9 lines

travis/

build_autotools.sh

6 lines

Diff 16811

View Options

src/secp256k1/src/tests.c