Page MenuHomePhabricator
Differential D5446

[CMAKE] Fix FindBerkeleyDB suffix paths
ClosedPublic
Actions

Authored by Fabien on Mar 8 2020, 09:41.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING8478751dace1: [CMAKE] Fix FindBerkeleyDB suffix paths
rABC8478751dace1: [CMAKE] Fix FindBerkeleyDB suffix paths
Summary

The FindBerkeleyDB module builds a combination of component and version
to search for the associated library, but use the same combination for
the suffix paths. However the suffix paths are always based on the name
db (not db_cxx) and can cause the search to fail on some systems.

Test Plan
cmake -GNinja ..
ninja

Run the Gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_fix_finddb
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9759
Build 17397: Default Diff Build & Tests
Build 17396: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 8 2020, 09:41
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 8 2020, 09:41
teamcity added a comment.Mar 8 2020, 09:41

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Mar 8 2020, 09:42

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Mar 8 2020, 09:42

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

teamcity added a comment.Mar 8 2020, 09:46

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Mar 8 2020, 09:46

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing started.

Harbormaster completed remote builds in B9759: Diff 16833.Mar 8 2020, 09:52
teamcity added a comment.Mar 8 2020, 09:52

Build Bitcoin-ABC / Diffs / Diff Testing passed.

teamcity added a comment.Mar 8 2020, 09:54

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

teamcity added a comment.Mar 8 2020, 09:56

Build Bitcoin-ABC / Diffs (Resource Intensive) / Bitcoin-ABC Gitian Diff Testing passed.

deadalnix accepted this revision.Mar 8 2020, 16:57
This revision is now accepted and ready to land.Mar 8 2020, 16:57
Closed by commit rABC8478751dace1: [CMAKE] Fix FindBerkeleyDB suffix paths (authored by Fabien). · Explain WhyMar 9 2020, 07:12
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC8478751dace1: [CMAKE] Fix FindBerkeleyDB suffix paths.
Fabien added a commit: rSTAGING8478751dace1: [CMAKE] Fix FindBerkeleyDB suffix paths.Apr 7 2020, 23:17

Revision Contents
Changeset List

PathSize
cmake/
modules/
47 lines

Diff 16833

View Options

cmake/modules/FindBerkeleyDB.cmake

Loading...