Page MenuHomePhabricator
Differential D5447

Rename DecodeDumpTime to ParseISO8601DateTime and move to time.cpp
ClosedPublic
Actions

Authored by deadalnix on Mar 8 2020, 17:33.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGINGc0f5ddc4a286: Rename DecodeDumpTime to ParseISO8601DateTime and move to time.cpp
rABCc0f5ddc4a286: Rename DecodeDumpTime to ParseISO8601DateTime and move to time.cpp
Summary
  • Add roundtrip and more tests to ParseISO8601DateTime and FormatISO8601DateTime

This is a backport of Core PR17266

Test Plan
ninja check-all

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr17266
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9760
Build 17399: Default Diff Build & Tests
Build 17398: arc lint + arc unit

Event Timeline

deadalnix created this revision.Mar 8 2020, 17:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 8 2020, 17:33
teamcity edited the summary of this revision. (Show Details)Mar 8 2020, 17:33

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 8 2020, 17:33

Build Bitcoin-ABC / Diffs / Diff Testing started.

teamcity added a comment.Mar 8 2020, 17:46

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9760: Diff 16835.Mar 8 2020, 17:46
deadalnix updated this revision to Diff 16836.Mar 8 2020, 18:17

Add roundtrip and more tests to ParseISO8601DateTime and FormatISO8601DateTime

teamcity added a comment.Mar 8 2020, 18:17

Build Bitcoin-ABC / Diffs / Diff Testing started.

deadalnix edited the summary of this revision. (Show Details)Mar 8 2020, 18:17
teamcity added a comment.Mar 8 2020, 18:27

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9761: Diff 16836.Mar 8 2020, 18:27
Fabien accepted this revision.Mar 9 2020, 09:22
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/util/time.cpp
118 ↗(On Diff #16836)

Newline

This revision is now accepted and ready to land.Mar 9 2020, 09:22
deadalnix updated this revision to Diff 16861.Mar 10 2020, 07:39

Add new line

teamcity added a comment.Mar 10 2020, 07:39

Build Bitcoin-ABC / Diffs / Diff Testing started.

This revision was landed with ongoing or failed builds.Mar 10 2020, 07:39
Closed by commit rABCc0f5ddc4a286: Rename DecodeDumpTime to ParseISO8601DateTime and move to time.cpp (authored by Elichai Turkel <elichai.turkel@gmail.com>, committed by deadalnix). · Explain Why
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rABCc0f5ddc4a286: Rename DecodeDumpTime to ParseISO8601DateTime and move to time.cpp.
teamcity added a comment.Mar 10 2020, 08:09

Build Bitcoin-ABC / Diffs / Diff Testing passed.

Harbormaster completed remote builds in B9780: Diff 16861.Mar 10 2020, 08:09
deadalnix added a commit: rSTAGINGc0f5ddc4a286: Rename DecodeDumpTime to ParseISO8601DateTime and move to time.cpp.Apr 7 2020, 23:17

Revision Contents
Changeset List

PathSize
src/
util/
1 line
16 lines
wallet/
21 lines

Diff 16835

View Options

src/util/time.h

Loading...
View Options

src/util/time.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...