Page MenuHomePhabricator

[CMAKE] Improve FindQREncode
ClosedPublic

Authored by Fabien on Mar 9 2020, 13:22.

Details

Summary

Find qrencode on the model of D5339. There is no version information
that can be extracted from the library, so the only benefit here is the
imported target and consistency with other modules.

Test Plan
ninja check

Build on OSX.
Run the Gitian builds.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cmake_find_qrencode
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9765
Build 17409: Default Diff Build & Tests
Build 17408: arc lint + arc unit

Event Timeline

Rebase on top of D5448 to make the windows gitian build happy.

This revision is now accepted and ready to land.Mar 11 2020, 03:09

Consider adding a TODO for the version number check, similar to what you have in https://reviews.bitcoinabc.org/D5452#change-1AwvRCc5Q4iq

This revision was automatically updated to reflect the committed changes.