Page MenuHomePhabricator
Differential D5485

Merge #14013: [doc] Add new regtest ports in man following #10825 ports reattributions
ClosedPublic
Actions

Authored by nakihito on Mar 16 2020, 19:55.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING9754edd01101: Merge #14013: [doc] Add new regtest ports in man following #10825 ports…
rABC9754edd01101: Merge #14013: [doc] Add new regtest ports in man following #10825 ports…
Summary

e8c4a1e36969d2ef816d9dfaaee979a8cf6bfffe Add new regtest ports in doc following #10825 ports reattributions (Antoine Riard)

Pull request description:

Following #10825, regtest ports for p2p connections and JSON-RPC connections have been remapped from 18333 and 18332 to 18444 and 18443. This change is not documented in the wiki or nowhere else and it's puzzling to guess why your regtest JSON-rpc connections all failed even if you're following the docs.

Tree-SHA512: e2a1b9b4059060d9ed0900c1554e124ed69ae3e4648474880795128e77c7324d68aba52e4acda2f47390a9c3d36629b777e3b8c0eb10f0e08a2b120c4119dff3

Backport of Core PR14013

Test Plan
ninja
./bitcoin --help -help-debug
./bitcoin-cli --help

Verify changes to help text

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14013
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9829
Build 17528: Default Diff Build & Tests
Build 17527: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 16 2020, 19:55
Owners added a reviewer: Restricted Owners Package.Mar 16 2020, 19:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 16 2020, 19:55
teamcity edited the summary of this revision. (Show Details)Mar 16 2020, 19:55

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 16 2020, 19:55

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 16 2020, 20:05

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9829: Diff 16955.Mar 16 2020, 20:05
deadalnix accepted this revision.Mar 17 2020, 02:31
This revision is now accepted and ready to land.Mar 17 2020, 02:31
Closed by commit rABC9754edd01101: Merge #14013: [doc] Add new regtest ports in man following #10825 ports… (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by nakihito). · Explain WhyMar 17 2020, 17:28
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC9754edd01101: Merge #14013: [doc] Add new regtest ports in man following #10825 ports….
nakihito added a commit: rSTAGING9754edd01101: Merge #14013: [doc] Add new regtest ports in man following #10825 ports….Apr 7 2020, 23:21

Revision Contents
Changeset List

PathSize
src/
14 lines
48 lines

Diff 16955

View Options

src/bitcoin-cli.cpp

Loading...
View Options

src/init.cpp

Loading...