Page MenuHomePhabricator
Differential D5487

Merge #14215: [qa] Use correct python index slices in example test
ClosedPublic
Actions

Authored by nakihito on Mar 16 2020, 20:37.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING2300ba031559: Merge #14215: [qa] Use correct python index slices in example test
rABC2300ba031559: Merge #14215: [qa] Use correct python index slices in example test
Summary

9dcb6763fb [qa] Use correct python index slices in example test (Suhas Daftuar)

Pull request description:

There's an off-by-one in the list indices used in example_test.py.

Tree-SHA512: d75b77c1e0b3931d02dfa043da4cb6fe8e62864a73717ce5c184d9dbeb25579342c6365cc7bbcc7c4382d76a320a528bf3c69107854dfc6fa704133d0ba11012

Backport of Core PR14215

Test Plan
test_runner.py example_test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR14215
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 9831
Build 17532: Default Diff Build & Tests
Build 17531: arc lint + arc unit

Event Timeline

nakihito created this revision.Mar 16 2020, 20:37
Owners added a reviewer: Restricted Owners Package.Mar 16 2020, 20:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 16 2020, 20:37
teamcity edited the summary of this revision. (Show Details)Mar 16 2020, 20:37

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 16 2020, 20:37

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 16 2020, 20:47

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9831: Diff 16957.Mar 16 2020, 20:47
deadalnix accepted this revision.Mar 17 2020, 02:33
This revision is now accepted and ready to land.Mar 17 2020, 02:33
Closed by commit rABC2300ba031559: Merge #14215: [qa] Use correct python index slices in example test (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyMar 17 2020, 17:48
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC2300ba031559: Merge #14215: [qa] Use correct python index slices in example test.
nakihito added a commit: rSTAGING2300ba031559: Merge #14215: [qa] Use correct python index slices in example test.Apr 7 2020, 23:21

Revision Contents
Changeset List

PathSize
test/
functional/
4 lines

Diff 16957

View Options

test/functional/example_test.py

Loading...