Page MenuHomePhabricator
Differential D5488

Merge #14282: [wallet] Remove -usehd
ClosedPublic
Actions

Authored by nakihito on Mar 16 2020, 22:34.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING6930534e47a3: Merge #14282: [wallet] Remove -usehd
rABC6930534e47a3: Merge #14282: [wallet] Remove -usehd
Summary

7ac911afe7 [docs] Add release notes for removing -usehd (John Newbery)
25548b2958 [wallet] Remove -usehd (John Newbery)

Pull request description:

`-usehd` is no longer used (except to tell the user that they've set it incorrectly for the wallet that they're loading). Remove it (in the same spirit as #14272)

Tree-SHA512: 5bdcd2bb9bb8504a01343595bcd1bd433d97b730255152c725103c1ac3fa3a9d9e5220a4c29d4c72307cf803e1c09d31080f83603c23dc77263846e17b1826f0

Backport of Core PR14282

Test Plan
ninja check
ninja check-functional

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Mar 16 2020, 22:34
Owners added a reviewer: Restricted Owners Package.Mar 16 2020, 22:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 16 2020, 22:34
teamcity edited the summary of this revision. (Show Details)Mar 16 2020, 22:35

[Bot Message]
One or more PR numbers were detected in the summary.
Links to those PRs have been inserted into the summary for reference.

teamcity added a comment.Mar 16 2020, 22:35

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) started.

teamcity added a comment.Mar 16 2020, 22:45

Build Bitcoin-ABC / Diffs / Diff Testing (build-diff) passed.

Harbormaster completed remote builds in B9834: Diff 16962.Mar 16 2020, 22:45
deadalnix accepted this revision.Mar 17 2020, 02:29
This revision is now accepted and ready to land.Mar 17 2020, 02:29
Closed by commit rABC6930534e47a3: Merge #14282: [wallet] Remove -usehd (authored by MarcoFalke <falke.marco@gmail.com>, committed by nakihito). · Explain WhyMar 17 2020, 17:54
This revision was automatically updated to reflect the committed changes.
nakihito added a commit: rABC6930534e47a3: Merge #14282: [wallet] Remove -usehd.
nakihito added a commit: rSTAGING6930534e47a3: Merge #14282: [wallet] Remove -usehd.Apr 7 2020, 23:21

Revision Contents
Changeset List

PathSize
doc/
6 lines
src/
2 lines
wallet/
22 lines
test/
functional/
7 lines
lint/
1 line

Diff 16985

View Options

doc/release-notes.md

Loading...
View Options

src/init.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

test/functional/wallet_hd.py

Loading...
View Options

test/lint/check-doc.py

Loading...